London | May-26 | Liridona Shehu | Sprint 2 | Book Library - #506
London | May-26 | Liridona Shehu | Sprint 2 | Book Library#506shehu-dona wants to merge 9 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
cjyuan
left a comment
There was a problem hiding this comment.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md
Doing so can help me speed up the review process. Thanks.
|
Hello @cjyuan I updated the work following the guide you send me. |
| const deletedTitle = book.title; | ||
| myLibrary.splice(i, 1); | ||
| render(); | ||
| console.log(`You've deleted title: ${deletedTitle}`); |
There was a problem hiding this comment.
This does not quite show the message to the user.
Suggestion: Look up a non-blocking approach to show messages.
|
Hello @cjyuan< |
|
Changes look good. Note: The checkboxes in the PR description is not properly encoded in Markdown syntax. |
Self checklist
Changelist
A PR with debugging exercises.